test: Use predictable accounts for TestTracingwithOverrides #4666
+46
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a flaky test (TestTracingWithOverrides) that fails approximately 1/256 times when randomly generated block hashes start with 0xef, which conflicts with London hard fork validation rules.
Key changes:
- Introduces deterministic account generation using a fixed random seed
- Adds
newAccountsWithSeedhelper function to generate predictable test accounts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JonathanOppenheimer
approved these changes
Dec 9, 2025
alarso16
changed the title
Co-authored-by: Copilot <[email protected]> Signed-off-by: Austin Larson <[email protected]>
ARR4N
requested changes
Dec 10, 2025
Contributor
ARR4N
left a comment
ARR4N
left a comment
There was a problem hiding this comment.
Good work in finding that! I'd usually try to understand why it happens, but this will all be deleted in time.
Contributor
Author
|
I'm not changing the dependencies right before subnet-evm merger, so I'll just wait to push for a review |
alarso16
commented
Dec 15, 2025
Contributor
Author
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
I had to update all the commits used in versioning to trick the go.mod into accepting the lower semantic version
alarso16
force-pushed
the
alarso16/tracing-overrides
branch
from
fa6d8c3 to
a55d7af
Compare
JonathanOppenheimer
added
coreth
alarso16
added
subnet-evm
ARR4N
approved these changes
Dec 16, 2025
Comment on lines
+1004
to
+1007
| func UNSAFEDeterministicAccounts(t *testing.T, n int) (accounts []Account) { | ||
| seed := make([]byte, 8) // int64 size | ||
| for i := 0; i < n; i++ { | ||
| binary.BigEndian.PutUint64(seed, uint64(i)) |
Contributor
There was a problem hiding this comment.
Suggested change
| func UNSAFEDeterministicAccounts(t *testing.T, n int) (accounts []Account) { | |
| seed := make([]byte, 8) // int64 size | |
| for i := 0; i < n; i++ { | |
| binary.BigEndian.PutUint64(seed, uint64(i)) | |
| func UNSAFEDeterministicAccounts(t *testing.T, n uint64) (accounts []Account) { | |
| seed := make([]byte, 8) // int64 size | |
| for i := range n { | |
| binary.BigEndian.PutUint64(seed, i) |
| addr := crypto.PubkeyToAddress(key.PublicKey) | ||
| accounts = append(accounts, Account{key: key, addr: addr}) | ||
| } | ||
| slices.SortFunc(accounts, func(a, b Account) int { return a.addr.Cmp(b.addr) }) |
| func testTracingWithOverrides(t *testing.T, scheme string) { | ||
| // Initialize test accounts | ||
| accounts := newAccounts(3) | ||
| // This test requires deterministic block hashes, since it will fail 1/256 times,Expand commentComment on line R635ResolvedCode has comments. Press enter to view. |
Contributor
There was a problem hiding this comment.
Expand commentComment on line R635ResolvedCode
?
Comment on lines
+1002
to
+1005
| func UNSAFEDeterministicAccounts(t *testing.T, n int) (accounts []Account) { | ||
| seed := make([]byte, 8) // int64 size | ||
| for i := 0; i < n; i++ { | ||
| binary.BigEndian.PutUint64(seed, uint64(i)) |
Contributor
There was a problem hiding this comment.
Suggested change
| func UNSAFEDeterministicAccounts(t *testing.T, n int) (accounts []Account) { | |
| seed := make([]byte, 8) // int64 size | |
| for i := 0; i < n; i++ { | |
| binary.BigEndian.PutUint64(seed, uint64(i)) | |
| func UNSAFEDeterministicAccounts(t *testing.T, n uint64) (accounts []Account) { | |
| seed := make([]byte, 8) // int64 size | |
| for i := range n { | |
| binary.BigEndian.PutUint64(seed, i) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This test flakes because every once in a while, the final block hash starts with
0xef, which is incompatible with the London hard fork. It's unintuitive that theErrInvalidCodeerror would be encountered for return values that are not code hashes, but this testing only fix will remove failures in CICloses #4560
How this works
Uses a random seed to pre-fill the state with the same data every time.
How this was tested
Locally, logging the resulting block hash.
Need to be documented in RELEASES.md?
No