fix(eth/tracers): fix crash in TraceCall with BlockOverrides #4657
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmkulazhenko
force-pushed
the
fix/debug_tracecall-crash-nil
branch
from
a9889fc to
e9cd4bf
Compare
alarso16
approved these changes
Dec 4, 2025
Contributor
alarso16
left a comment
alarso16
left a comment
There was a problem hiding this comment.
This seems like a reasonable check
Member
|
Typically we try to avoid modifying upstream geth code to avoid increase the diff. @dmkulazhenko -- does this aline with the latest of the file in https://github.com/ethereum/go-ethereum? |
Author
JonathanOppenheimer
approved these changes
Dec 5, 2025
Member
|
Got it! Rather than making the changes yourself, can you cherry-pick that commit? That's how we've typically done geth chaanges AFAIK. |
JonathanOppenheimer
added
coreth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with
debug_traceCallmethod crash (panic) whenBlockOverridespassed, butBlockOverrides.Number == nil