Conversation
I've done so! That PR is available here: ava-labs/libevm#250 I've removed the pseudo check from this PR, and also remove the tests this replaces. This PR is relevant as Austin and I worked through the subnet-evm monorepo PRs, with some assumptions that this PR enforces. |
|
The above PR is now merged in. Thanks to @maru-ava for the suggestion. |
alarso16
left a comment
There was a problem hiding this comment.
This is definitely worth some more thought about exactly what we want to enforce, and the boolean logic is overly complicated (and incorrect I think)
Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com> Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com>
maru-ava
left a comment
There was a problem hiding this comment.
lgtm but I leave it to an evm team member to merge.
Why this should be merged
This PR prevents files inside of the
vms/evmdirectory from importing packages within thegraft/directory.Closes #4541, #4643
How this works
The boundaries are as follows:
graft/corethcan be imported everywhere in AvalancheGo exceptvms/evm.vms/evm/emulateis an exception to this rulegraft/subnet-evmcan not be imported anywhere in AvalancheGovms/evm/emulateis an exception to this ruleHow this was tested
Existing CI.
Need to be documented in RELEASES.md?
No