Skip to content

Conversation

@maru-ava
Copy link
Contributor

@maru-ava maru-ava commented Nov 20, 2025

Why this should be merged

Migrates coreth to graft/coreth as per #4530

This is basically impossible to review directly, so reviewers are encouraged to review the script that performed the merge and to reproduce the branch locally to gain confidence that this PR represents the results of that script.

cd graft
task coreth-subtree-merge

How this works

See #4531

How this was tested

  • CI will pass only once child PRs are merged into this one

Need to be documented in RELEASES.md?

N/A

aaronbuchwald and others added 30 commits May 9, 2025 15:09
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Copilot <[email protected]>
Signed-off-by: aaronbuchwald <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: David Klank <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Co-authored-by: Michael Kaplan <[email protected]>
alarso16 and others added 20 commits November 3, 2025 22:49
Signed-off-by: Austin Larson <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Austin Larson <[email protected]>
Co-authored-by: Jonathan Oppenheimer <[email protected]>
…18.1 (#1385)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Co-authored-by: Austin Larson <[email protected]>
…1b5f4a752c7b0eb8226f55bc'

git-subtree-dir: graft/coreth
git-subtree-mainline: efc915f
git-subtree-split: 4819e74
@maru-ava maru-ava self-assigned this Nov 20, 2025
@maru-ava maru-ava linked an issue Nov 20, 2025 that may be closed by this pull request
9 tasks
@maru-ava maru-ava moved this to In Progress 🏗️ in avalanchego Nov 20, 2025
@maru-ava maru-ava changed the title [migrate-coreth][2] Add 'graft/coreth/' from commit '4819e747894397071b5f4a752c7b0eb8226f55bc' [migrate-coreth][2] Add 'graft/coreth/' from commit 4819e747 Nov 20, 2025
@maru-ava maru-ava moved this from In Progress 🏗️ to Ready 🚦 in avalanchego Nov 20, 2025
Copy link
Contributor

@alarso16 alarso16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the same script and got the following diff:

diff --git a/graft/scripts/subtree-merge.sh b/graft/scripts/subtree-merge.sh
index 465cdac0b3..a5f968ca63 100755
--- a/graft/scripts/subtree-merge.sh
+++ b/graft/scripts/subtree-merge.sh
@@ -17,10 +17,6 @@ set -euo pipefail
 # The target path is automatically derived as graft/[repo-name] where repo-name
 # is the last component of the module path.
 #
-# Prerequisites:
-#   - Must be run from a git repository
-#   - Target path must not already exist
-#
 # What this script does:
 #   1. Constructs repository URL from module path
 #   2. Discovers version from go.mod if not provided

So looks great!

@maru-ava maru-ava requested a review from PlatCore November 20, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Ready 🚦

Development

Successfully merging this pull request may close these issues.

Migrate coreth repo to grafts/coreth