-
Notifications
You must be signed in to change notification settings - Fork 834
[migrate-coreth][2] Add 'graft/coreth/' from commit 4819e747 #4532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
maru-ava
wants to merge
3,681
commits into
maru/migrate-coreth-add-tooling
Choose a base branch
from
maru/migrate-coreth-subtree-merge
base: maru/migrate-coreth-add-tooling
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[migrate-coreth][2] Add 'graft/coreth/' from commit 4819e747 #4532
maru-ava
wants to merge
3,681
commits into
maru/migrate-coreth-add-tooling
from
maru/migrate-coreth-subtree-merge
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]> Co-authored-by: Quentin McGaw <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Copilot <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Copilot <[email protected]>
Signed-off-by: aaronbuchwald <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: David Klank <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Ceyhun Onur <[email protected]> Co-authored-by: Michael Kaplan <[email protected]>
Signed-off-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Austin Larson <[email protected]> Co-authored-by: Jonathan Oppenheimer <[email protected]>
…18.1 (#1385) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]> Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Austin Larson <[email protected]> Co-authored-by: Stephen Buttolph <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]>
Signed-off-by: Jonathan Oppenheimer <[email protected]> Co-authored-by: Austin Larson <[email protected]>
…ext pattern (#1417) Signed-off-by: Tsvetan Dimitrov ([email protected])
9 tasks
alarso16
approved these changes
Nov 20, 2025
Contributor
alarso16
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the same script and got the following diff:
diff --git a/graft/scripts/subtree-merge.sh b/graft/scripts/subtree-merge.sh
index 465cdac0b3..a5f968ca63 100755
--- a/graft/scripts/subtree-merge.sh
+++ b/graft/scripts/subtree-merge.sh
@@ -17,10 +17,6 @@ set -euo pipefail
# The target path is automatically derived as graft/[repo-name] where repo-name
# is the last component of the module path.
#
-# Prerequisites:
-# - Must be run from a git repository
-# - Target path must not already exist
-#
# What this script does:
# 1. Constructs repository URL from module path
# 2. Discovers version from go.mod if not provided
So looks great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Migrates coreth to graft/coreth as per #4530
This is basically impossible to review directly, so reviewers are encouraged to review the script that performed the merge and to reproduce the branch locally to gain confidence that this PR represents the results of that script.
cd graft task coreth-subtree-mergeHow this works
See #4531
How this was tested
Need to be documented in RELEASES.md?
N/A