Skip to content

chore: Add EVM linters#4444

Merged
StephenButtolph merged 2 commits intomasterfrom
JonathanOppenheimer/add-evm-linters
Oct 31, 2025
Merged

chore: Add EVM linters#4444
StephenButtolph merged 2 commits intomasterfrom
JonathanOppenheimer/add-evm-linters

Conversation

@JonathanOppenheimer
Copy link
Copy Markdown
Contributor

Why this should be merged

Currently, the EVM repositories contain linters that AvalancheGo does not have (and vice versa but that is not important). As we will be merging these two repositories soon, this helps unify the CI linting.

How this works

  • bidichk - Checks for dangerous unicode character sequences
  • durationcheck - Checks for two durations multiplied together
  • gocheckcompilerdirectives - Checks that go compiler directive comments are valid
  • mirror - Reports wrong mirror patterns of bytes/strings usage
  • reassign - Checks that package variables are not reassigned

How this was tested

CI

Need to be documented in RELEASES.md?

No

@JonathanOppenheimer JonathanOppenheimer self-assigned this Oct 30, 2025
@JonathanOppenheimer JonathanOppenheimer added the ci This focuses on changes to the CI process label Oct 30, 2025
@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 31, 2025
Merged via the queue into master with commit 482d65d Oct 31, 2025
59 of 60 checks passed
@StephenButtolph StephenButtolph deleted the JonathanOppenheimer/add-evm-linters branch October 31, 2025 15:19
@github-project-automation github-project-automation bot moved this to Done 🎉 in avalanchego Oct 31, 2025
demosdemon added a commit to ava-labs/firewood that referenced this pull request Oct 31, 2025
exec: `.github/scripts/verify_golangci_yaml_changes.sh apply` 

updated by ava-labs/avalanchego#4444
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci This focuses on changes to the CI process

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants