chore(sync/message): migrate message package for EVM state sync from coreth
#4417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`coreth` - Introduce vms/evm/sync/message with request/response types: - BlockRequest/Response, LeafsRequest/Response, CodeRequest/Response. - Add Request and RequestHandler interfaces and wiring. - Add codec setup with versioning and max message size. - Add BlockSyncSummary and parser for sync bootstrap. - Add golden serialization tests and table-driven tests for handler dispatch and interface round-trips. resolves #4416 Signed-off-by: Tsvetan Dimitrov ([email protected])
DracoLi
reviewed
Oct 14, 2025
| // BlockResponse is a response to a BlockRequest | ||
| // Blocks is slice of RLP encoded blocks starting with the block | ||
| // requested in BlockRequest.Hash. The next block is the parent, etc. | ||
| // handler: handlers.BlockRequestHandler |
There was a problem hiding this comment.
this is referring to the handlers package in coreth right? are we looking to move this over as well?
There was a problem hiding this comment.
yes, sorry I missed this reference in the comment, but the handlers will be migrated as well in a follow up PR.
DracoLi
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Check #4416
How this works
How this was tested
Existing and added UT in the package itself.
Need to be documented in RELEASES.md?
no
resolves #4416
Signed-off-by: Tsvetan Dimitrov ([email protected])