feat(sync/customrawdb): migrate customrawdb package from coreth #4387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `plugin/evm/customrawdb` in `coreth` to `vms/evm/sync` in `avalanchego` as part of state sync code migration effort. resolves #4386 Signed-off-by: Tsvetan Dimitrov ([email protected])
powerslider
force-pushed
the
powerslider/4386-migrate-customrawdb-coreth
branch
from
296bb75 to
fff1df9
Compare
joshua-kim
reviewed
Oct 8, 2025
… assertions - Add tests: - Time markers (offline_pruning, populate_missing_tries): missing marker and bad-encoding cases. - Pruning disabled flag: presence toggling. - Acceptor tip: invalid length error and write/read behavior (table-driven: none, single_write, overwrite). - State sync: sync root read/write, code-to-fetch iterate/delete, segments/storage tries iterate/unpack/clear, sync performed latest (empty/increasing/unsorted). - Snapshot: block hash read/write/delete and account iterator key-length filtering. - ParseStateSchemeExt: Firewood on empty DB, conflict on existing scheme, passthrough for "hash". - Refactor/behavioral tightening (internal-only): - Add unexported sentinels: errMarkerNotFound, errMarkerInvalid, errAcceptorTipInvalid. - Normalize time marker reads: use `Has()` for presence and return `errMarkerNotFound` when absent/empty. Wrap decode errors with `errMarkerInvalid`. - Wrap acceptor tip invalid-length with `errAcceptorTipInvalid`. - Tests assert with `require.ErrorIs` for known sentinels. - Schema organization: - Group all package-level globals in a single var block in schema_ext.go - Add clear section headers to improve readability
|
@joshua-kim I added lots of new tests that enable having the following coverage for the package: I fixed most of the minor comments and will get back on the rest of your points once I have more historical context from the team. |
… add sentinel errors, fix tests - Replace geth-style zero/nil read returns with explicit errors across customrawdb. - Add exported sentinel errors: - ErrEntryNotFound, ErrInvalidData, ErrStateSchemeConflict, ErrInvalidArgument - Update accessors to return errors consistently. - Align tests with new errors and function signatures. - Convert cases to table-driven, snake_case names. - Add no-op clear tests for segments/storage tries. - Add invalid-length/invalid-encoding tests (snapshot block hash, time markers). - Add iterator error checks after loops.
… add sentinel errors, fix tests - Replace geth-style zero/nil read returns with explicit errors across customrawdb. - Add exported sentinel errors: - ErrEntryNotFound, ErrInvalidData, ErrStateSchemeConflict, ErrInvalidArgument - Update accessors to return errors consistently. - Align tests with new errors and function signatures. - Convert cases to table-driven, snake_case names. - Add no-op clear tests for segments/storage tries. - Add invalid-length/invalid-encoding tests (snapshot block hash, time markers). - Add iterator error checks after loops.
|
@joshua-kim all comments should be fixed. Discussed with the team to omit |
joshua-kim
reviewed
Oct 15, 2025
…sibilities - Rename scheme.go -> db.go (state scheme parsing, shared package items). - Rename state_sync.go -> sync_progress.go (state sync progress + iterators). - Merge snapshot helpers into markers.go (all node/chain metadata in one place). - De-flake and simplify tests: - Make time-marker writes deterministic by passing a fixed timestamp in tests - Simplify ReadChainConfig tests, remove mutate case and rely on dedicated invalid JSON test. - Use require.ErrorIs consistently for error assertions.
joshua-kim
reviewed
Oct 15, 2025
joshua-kim
reviewed
Oct 15, 2025
joshua-kim
reviewed
Oct 15, 2025
joshua-kim
reviewed
Oct 17, 2025
joshua-kim
approved these changes
Oct 17, 2025
DracoLi
reviewed
Oct 17, 2025
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestParseStateScheme(t *testing.T) { |
There was a problem hiding this comment.
No action required, but I'd probably slightly prefer this as a test vector... Admittedly this might be more succinct as is.
StephenButtolph
approved these changes
Oct 20, 2025
StephenButtolph
deleted the
powerslider/4386-migrate-customrawdb-coreth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Check #4386
How this works
plugin/evm/customrawdbincorethtovms/evm/syncinavalanchegoas part of state sync code migration effort.geth-style zero/nil read returns with explicit errors across customrawdb.ErrEntryNotFound,ErrInvalidData,ErrStateSchemeConflict,ErrInvalidArgumentHow this was tested
Existing UT that come with the migrated code plus newly added UT to cover the entire package API.
Need to be documented in RELEASES.md?
no
resolves #4386
Signed-off-by: Tsvetan Dimitrov ([email protected])