feat(reexecution/c): add metervm metrics#4369
Merged
aaronbuchwald merged 16 commits intomasterfrom Oct 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds metervm metrics to the re-execution test to provide more precise performance assessment by tracking time spent in block parsing/verification/acceptance. Changes the metric unit from mGas/s to ms/gGas for better metric comparison.
- Integrates metervm to track block processing phases
- Changes metric reporting from throughput to time-per-unit format
- Moves metrics handling to a dedicated file for better organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/reexecute/c/vm_reexecute_test.go | Adds metervm integration and removes old metrics functions |
| tests/reexecute/c/metrics.go | New file containing metrics collection and reporting logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Collaborator
|
Can we use mgas/s and ggas/s rather than camel case? That's how I've typically seen it and follows the current use of |
Collaborator
|
Note: need to ensure that the newly added metrics show up as desired in the benchmarks page. |
aaronbuchwald
approved these changes
Sep 30, 2025
Elvis339
approved these changes
Oct 1, 2025
RodrigoVillar
added a commit
that referenced
this pull request
Oct 6, 2025
This reverts commit 613219c.
This was referenced Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this should be merged
As mentioned in #4282, it would be great if we could have a more precise assessment for the re-execution test rather than printing the average
mGas/sfor the entire benchmark. The starting point point for increasing the precision of the re-execution test would be to record the time spent in block parsing/verification/acceptance (whose sum should equal the total re-execution benchmark time).How this works
ms/gGasto allow for a more straightforward comparison between metrics.How this was tested
CI + ran re-execution test locally to verify that the sum of block parsing/verification/acceptance is just about equal to the total re-execution benchmark time.
Need to be documented in RELEASES.md?
No