Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACP-77: Update warp messages to align with spec changes #3430

Merged
merged 3 commits into from
Oct 1, 2024
Merged

ACP-77: Update warp messages to align with spec changes #3430

merged 3 commits into from
Oct 1, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

This PR updates the vms/platformvm/warp/message package to align with the suggested changes to the ACP-77 spec.

How this works

  • Removes the duplicate warp message for weight tracking (they can be re-used).
  • Updates the RegisterSubnetValidator definition to include addresses
  • Implements a verification helper for RegisterSubnetValidator
  • Implements a helper to generate a SubnetConversionID
  • Implements a verification helper for SubnetValidatorWeight

How this was tested

  • Updated all unit tests and spec vectors

@StephenButtolph StephenButtolph added this to the v1.11.12 milestone Oct 1, 2024
@StephenButtolph StephenButtolph self-assigned this Oct 1, 2024
michaelkaplan13
michaelkaplan13 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@michaelkaplan13 michaelkaplan13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message specs all make sense to me. Just one question on the name of SubnetValidatorWeight

cam-schultz
cam-schultz approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@cam-schultz cam-schultz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all makes sense to me.

@StephenButtolph StephenButtolph added this pull request to the merge queue Oct 1, 2024
Merged via the queue into master with commit 7fd21ca Oct 1, 2024
22 checks passed
@StephenButtolph StephenButtolph deleted the implement-acp-77-update-warp-messages branch October 1, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@cam-schultz cam-schultz cam-schultz approved these changes

Assignees

@StephenButtolph StephenButtolph

Labels
acp77
Projects
Platform Engineering Group
Status: Done ✅
Milestone
v1.11.12
Development

Successfully merging this pull request may close these issues.
3 participants
@StephenButtolph @michaelkaplan13 @cam-schultz