-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make snowman use snowflake directly instead of snowball #3403
Open
yacovm
wants to merge
4
commits into
ava-labs:master
Choose a base branch
from
yacovm:removeSnowball
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yacovm
force-pushed
the
removeSnowball
branch
from
September 19, 2024 18:49
2054a80
to
484d447
Compare
Snowball was introduced in order to improve the stability of snowflake, by taking into account the history when returning the preference. However, if deployed with a configuration where the preference is small enough, and a network partition causes a 50-50 split of the stake, it can actually backfire, as described in 6e1a905. Additionally, latest research [1] points out that snowflake suffices for snowman. This commit removes snowball from snowman and adds a test that simulates a mixed network which runs snowman with and without snowball, and ensures that a mixed network still converges. [1] https://arxiv.org/abs/2404.14250 Signed-off-by: Yacov Manevich <[email protected]>
yacovm
force-pushed
the
removeSnowball
branch
from
September 19, 2024 19:08
484d447
to
e3597d8
Compare
michaelkaplan13
requested review from
aaronbuchwald,
joshua-kim and
ceyonur
September 24, 2024 16:15
marun
reviewed
Sep 27, 2024
marun
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Snowball was introduced in order to improve the stability of snowflake, by taking into account the history when returning the preference.
However, if deployed with a configuration where the preference is small enough, and a network partition causes a 50-50 split of the stake, it can actually backfire, as described in 6e1a905.
Additionally, latest research [1] points out that snowflake suffices for snowman.
[1] https://arxiv.org/abs/2404.14250
How this works
This commit removes snowball from snowman by substituting the snowball factory snowman uses, with a snowflake factory.
How this was tested
Added a test that simulates a mixed network which runs snowman with and without snowball, and ensures that a mixed network still converges.
Also ran a modified node on Fuji and monitored its consensus related metrics, and it seemed functioning well.