[antithesis] Ensure references to pushed images are qualified #3264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
approved these changes
Aug 2, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
marun
added a commit
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes publication of antithesis images broken by #3198.
How this works
Qualifies the name of the base node image if the image build was configured to push the base node image to a repo. Previously the name was never qualified so that a local (non-pushing) build would work fine but the publication job would fail.
How this was tested
Manually triggered publication workflow on the PR branch:
https://github.com/ava-labs/avalanchego/actions/runs/10222587198