Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename GetPeerList and PeerList messages #3182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

won-js
Copy link

@won-js won-js commented Jul 9, 2024

Why this should be merged

Resolve #3128

Discussion and alternatives
I have not changed the "peerLists" in network/network.go.
Should I change it to peers?

How this works

  • peerList -> peers
  • get_peerList -> peers
  • Cli flags and comments (peer-list && peerlist -> peers)

How this was tested

config/config.go Outdated
PeerListNumValidatorIPs: v.GetUint32(NetworkPeerListNumValidatorIPsKey),
PeerListPullGossipFreq: v.GetDuration(NetworkPeerListPullGossipFreqKey),
PeerListBloomResetFreq: v.GetDuration(NetworkPeerListBloomResetFreqKey),
PeersGossipConfig: network.PeersGossipConfig{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applicable to the similar spots in this PR but we should name this PeerGossipConfig since PeersGossipConfig reads awkwardly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing.
I am not a native English speaker, so I'm not very familiar with it.
I have made the changes.

@won-js won-js requested a review from joshua-kim July 10, 2024 06:37
Copy link

github-actions bot commented Sep 1, 2024

This PR has become stale because it has been open for 30 days with no activity. Adding the lifecycle/frozen label will cause this PR to ignore lifecycle events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress 🏗
Development

Successfully merging this pull request may close these issues.

Rename GetPeerList and PeerList messages
2 participants