Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Fixes deadlock observed here.
Currently it's possible that:
Shutdown
is called with the context lock heldGossip
is calledGossip
the validator set needs to be recalculatedShutdown
blocks untilGossip
returnsHow this works
The options here are:
Shutdown
prior to waiting and then re-grabbing itGossip
inShutdown
.This PR takes approach 2. Technically this could cause unexpected warnings to be logged... I felt like this was better than releasing the context lock in
Shutdown
. Hopefully all of this will be cleaned up once we push the context lock into the VMs.How this was tested