-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update go.uber.org/mock/gomock
to v0.4.0
#2618
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Should there be a similar PR for coreth? For otherwise we'll have different versions for mocks in the two repos
The mock differences is in |
Why this should be merged
We'll be using some of the new features in #2615. This was made to reduce the diff.
How this works
Bump dependency + re-run mockgen.
How this was tested
CI