Add constructors to the SDK #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
danlaine and
StephenButtolph
as code owners
ceyonur
reviewed
Dec 12, 2023
| } | ||
|
|
||
| func (t ThrottlerHandler) CrossChainAppRequest(ctx context.Context, chainID ids.ID, deadline time.Time, requestBytes []byte) ([]byte, error) { | ||
| return t.handler.CrossChainAppRequest(ctx, chainID, deadline, requestBytes) |
There was a problem hiding this comment.
I guess we don't want to handle this case?
There was a problem hiding this comment.
Yeah... this is the same behavior as before but my thought was that it didn't make sense to throttle messages from ourselves. I think we should probably still throttle anyways, but probably in a future PR. Currently nothing is using this.
joshua-kim
force-pushed
the
add-constructors
branch
2 times, most recently
from
654fab9 to
c8171f3
Compare
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
Signed-off-by: Joshua Kim <[email protected]>
joshua-kim
force-pushed
the
add-constructors
branch
from
c8171f3 to
2524339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Gets rid of issues with nil pointers
How this works
Adds constructor functions
How this was tested
CI