Skip to content

Conversation

@StephenButtolph
Copy link
Contributor

Why this should be merged

msgHandlingTime is documented to be the time spent handling a message after the context lock is grabbed. However, it is incorrectly reporting the amount of time spent grabbing the context lock.

How this works

Correctly calculates the amount of time spent processing the message after the lock is grabbed.

How this was tested

CI

@StephenButtolph StephenButtolph self-assigned this Apr 27, 2023
@StephenButtolph StephenButtolph added bug Something isn't working monitoring This primarily focuses on logs, metrics, and/or tracing incident response labels Apr 27, 2023
@StephenButtolph StephenButtolph added this to the v1.10.1 milestone Apr 27, 2023
@StephenButtolph StephenButtolph merged commit 90a1238 into dev Apr 27, 2023
@StephenButtolph StephenButtolph deleted the fix-msg-handling-time branch April 27, 2023 17:15
joshua-kim pushed a commit to joshua-kim/avalanchego that referenced this pull request Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working incident response monitoring This primarily focuses on logs, metrics, and/or tracing

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants