Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Place sanity checks on Username and Password length on RPC keystore.createUser method #13

Merged
merged 9 commits into from
Mar 18, 2020
Merged

Place sanity checks on Username and Password length on RPC keystore.createUser method #13

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
1aef6e1
added sanity checks on user/pass string length when creating user via…
swdee Mar 13, 2020
c737fb8
removed commit from another branch, due to not branching from master …
swdee Mar 13, 2020
33ed4b5
change format of errUserPassMaxLength
swdee Mar 13, 2020
946fb66
added in checking of password strength when creating a new user
swdee Mar 13, 2020
2d0f56b
log call to createuser even if rejected by username/password length b…
swdee Mar 16, 2020
d27aa66
changed error message when password is rejected
swdee Mar 16, 2020
93d2e66
fix build problem with limiting length of username output when logging
swdee Mar 16, 2020
05a2bcb
fix spelling typo
swdee Mar 17, 2020
0d29aed
Merge branch 'master' into rpc-userpass-checks
StephenButtolph Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/keystore/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const (
var (
errEmptyUsername = errors.New("username can't be the empty string")
errUserPassMaxLength = fmt.Errorf("CreateUser call rejected due to username or password exceeding maximum length of %d chars", maxUserPassLen)
errWeakPassword = errors.New("Failed to create user as the given password is to weak. Passwords must be 8 or more characters and contain a combination of UPPER and lowercase letters, numbers, and special characters")
errWeakPassword = errors.New("Failed to create user as the given password is to weak. A stronger password is one of 8 or more characters containing attributes of upper and lowercase letters, numbers, and/or special characters")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to should be too

)

// KeyValuePair ...
Expand Down