Skip to content

Commit

Permalink
fixup: Address review feedback #2
Browse files Browse the repository at this point in the history
  • Loading branch information
marun committed Aug 8, 2023
1 parent 8bfe33d commit 60214e8
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion tests/e2e/e2e.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const (

// Interval appropriate for network operations that should be
// retried periodically but not too often.
DefaultPollingInterval = 1 * time.Millisecond
DefaultPollingInterval = 500 * time.Millisecond
)

// Env is used to access shared test fixture. Intended to be
Expand Down
21 changes: 11 additions & 10 deletions tests/fixture/test_data_server_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import (

"github.com/stretchr/testify/require"

"github.com/ava-labs/avalanchego/ids"
"github.com/ava-labs/avalanchego/utils/crypto/secp256k1"
)

Expand All @@ -32,21 +33,21 @@ func TestAllocateFundedKeys(t *testing.T) {
testCases := []struct {
name string
count int
expectedAddresses []string
expectedAddresses []ids.ShortID
}{{
name: "single key",
count: 1,
expectedAddresses: []string{
keys[4].Address().String(),
expectedAddresses: []ids.ShortID{
keys[4].Address(),
},
}, {
name: "multiple keys",
count: 4,
expectedAddresses: []string{
keys[0].Address().String(),
keys[1].Address().String(),
keys[2].Address().String(),
keys[3].Address().String(),
expectedAddresses: []ids.ShortID{
keys[0].Address(),
keys[1].Address(),
keys[2].Address(),
keys[3].Address(),
},
}, {
name: "insufficient keys available",
Expand All @@ -59,9 +60,9 @@ func TestAllocateFundedKeys(t *testing.T) {
require.ErrorIs(err, errRequestedKeyCountExceedsAvailable)
} else {
require.NoError(err)
addresses := []string{}
addresses := []ids.ShortID{}
for _, key := range keys {
addresses = append(addresses, key.Address().String())
addresses = append(addresses, key.Address())
}
require.Equal(tc.expectedAddresses, addresses)
}
Expand Down

0 comments on commit 60214e8

Please sign in to comment.