Signer multichain #167
Closed
Signer multichain #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukantoraymond
changed the base branch from
server-wallet-api-cli
to
reorganize-wallet
sukantoraymond
changed the base branch from
reorganize-wallet
to
server-wallet-api-cli
sukantoraymond
commented
Sep 30, 2025
| ) | ||
|
|
||
| // SignTx constructs a transaction for the specified operation | ||
| func SignTx(ctx context.Context, wallet *primary.Wallet, params SignTxParams) (tx.SignTxResult, error) { |
There was a problem hiding this comment.
So we can have one sign function that can be used across all chains, and have said function consumed by all implementations of wallet interface
sukantoraymond
commented
Sep 30, 2025
Comment on lines
+34
to
+44
| // BuildTxOutput represents a generic interface for transaction results | ||
| type BuildTxOutput interface { | ||
| // GetTxType returns the transaction type identifier | ||
| GetTxType() string | ||
| // GetChainType returns which chain this transaction is for | ||
| GetChainType() string | ||
| // GetTx returns the actual transaction (interface{} to support different chain types) | ||
| GetTx() interface{} | ||
| // Validate validates the result | ||
| Validate() error | ||
| } |
There was a problem hiding this comment.
To support multi chain Build Tx result
sukantoraymond
commented
Sep 30, 2025
| ) | ||
|
|
||
| // BuildTx constructs a transaction for the specified operation | ||
| func BuildTx(ctx context.Context, wallet *primary.Wallet, params BuildTxParams) (tx.BuildTxResult, error) { |
There was a problem hiding this comment.
abstracting BuildTx into builder.go so that this function can be used by local wallet and server wallet so we can reuse the same function
sukantoraymond
commented
Sep 30, 2025
|
|
||
| // BuildTx constructs a transaction for the specified operation | ||
| func (w *LocalWallet) BuildTx(ctx context.Context, params BuildTxParams) (tx.BuildTxResult, error) { | ||
| func (w *LocalWallet) BuildTx(ctx context.Context, params wallet.BuildTxParams) (tx.BuildTxResult, error) { |
There was a problem hiding this comment.
This function will now be used by all wallet implementations for signing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates one Signer function for all chains that can be used by all wallet implementations.
This PR also reorganizes files to be in line with local wallet / server wallet separation