Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add config file + network upgrade support to blockchain creation #316

Merged
merged 18 commits into from
Oct 25, 2022
Merged

Add config file + network upgrade support to blockchain creation #316

merged 18 commits into from
Oct 25, 2022

Conversation

felipemadero
Copy link
Collaborator

@felipemadero felipemadero commented Oct 22, 2022 •
edited
Loading

Closes #314

holisticode
holisticode reviewed Oct 24, 2022
View reviewed changes
Copy link
Contributor

@holisticode holisticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.

I left a couple of comments which should be easy to address. Only one more important issue.

local/blockchain.go Outdated Show resolved Hide resolved
local/blockchain.go Show resolved Hide resolved
local/blockchain.go Show resolved Hide resolved
local/blockchain.go Outdated Show resolved Hide resolved
local/blockchain.go Show resolved Hide resolved
server/server.go Show resolved Hide resolved
@felipemadero felipemadero mentioned this pull request Oct 24, 2022
Open
@felipemadero felipemadero merged commit 1542cd2 into main Oct 25, 2022
@felipemadero felipemadero deleted the config-upgrade-on-blockchain-creation branch October 25, 2022 14:52
@felipemadero felipemadero restored the config-upgrade-on-blockchain-creation branch October 25, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holisticode holisticode holisticode approved these changes

@patrick-ogrady patrick-ogrady Awaiting requested review from patrick-ogrady

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for passing in a custom VM config
2 participants
@felipemadero @holisticode