Unify ANR logging #230
Merged
Unify ANR logging #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pretty nice work. I think a CLI-similar ux function is needed to replace some outputs.
Also, not sure about direct redirection of avago stdout/stderr without logging/ux intervention.
Probably the redirection should pass under a ux function, avoiding saving to log file in that case, but enabling a future quiet flag usage.
fix some error %s that should be %v due to possible nil error
fix two %w not associated to the PR
felipemadero
approved these changes
Aug 16, 2022
…unner-local into 225-logging
…unner-local into 225-logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #225