Skip to content

uncomment previous flakey test #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2025
Merged

uncomment previous flakey test #272

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions replication_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@ func TestReplicationStuckInProposingBlock(t *testing.T) {
// have a stale notarization for a round(i.e. a node notarized a block but the rest of the network
// propagated an empty notarization).
func TestReplicationNodeDiverges(t *testing.T) {
t.Skip("flaky test, should re-enable with the fix for https://github.com/ava-labs/Simplex/issues/262")
nodes := []simplex.NodeID{{1}, {2}, {3}, {4}, {5}, {6}}
numBlocks := uint64(5)

Expand Down Expand Up @@ -807,7 +806,19 @@ func TestReplicationNodeDiverges(t *testing.T) {
}

net.Connect(laggingNode.E.ID)
net.TriggerLeaderBlockBuilder(numBlocks + 1)

for _, n := range net.Instances {
// TODO: remove when replication can be initiated with empty notarizations
if n.E.ID.Equals(laggingNode.E.ID) {
continue
}
WaitToEnterRound(t, n.E, numBlocks+1)
}

// we are in round 6(which means node 1 should be leader(but it is blacklisted))
net.AdvanceWithoutLeader(startTimes, 1+numBlocks, laggingNode.E.ID)

net.TriggerLeaderBlockBuilder(numBlocks + 2)
for _, n := range net.Instances {
n.Storage.WaitForBlockCommit(numBlocks - missedSeqs + 1)
}
Expand Down