Replace WMIC with powershell cmdlet #4242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leidwang
force-pushed
the
wmic_replacement
branch
6 times, most recently
from
6e2ab3d to
cc6d71a
Compare
|
depends on avocado-framework/avocado-vt#4034 |
|
OK. I am running the acceptance test within this patch and the avocado-vt patch. I will sync the test result when it is done. |
heywji
approved these changes
Jan 9, 2025
Great, thank you. |
|
Hi @XueqiangWei @nanliu-r @fbq815 Would you please help test this MR, it is mainly for wmic repalcement.Thanks. |
heywji
suggested changes
Jan 15, 2025
From Win11-24H2, Windows remove WMIC, so replace it with some powershell cmdlet Signed-off-by: Leidong Wang <[email protected]>
leidwang
force-pushed
the
wmic_replacement
branch
from
cc6d71a to
c686277
Compare
heywji
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
LGTM
(1/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(1/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (825.80 s)
(2/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(2/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (633.83 s)
(3/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: STARTED
(3/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.unattended_install.cdrom.extra_cdrom_ks.default_install.aio_threads.q35: PASS (1099.58 s)
(4/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: STARTED
(4/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: PASS (147.48 s)
(5/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: STARTED
(5/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win10.i386.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: PASS (116.34 s)
(6/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: STARTED
(6/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: PASS (56.63 s)
(7/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: STARTED
(7/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2016.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: PASS (48.22 s)
(8/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: STARTED
(8/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_sync.q35: PASS (102.38 s)
(9/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: STARTED
(9/9) Host_RHEL.m10.u0.qcow2.virtio_scsi.up.virtio_net.Guest.Win2019.x86_64.io-github-autotest-qemu.qemu_guest_agent.virtio_serial.check_powerdown.q35: PASS (83.43 s)
RESULTS : PASS 9 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
|
Acceptance test looks good. |
|
Hi @yanan-fu @YongxueHong Would you please help review this MR?Thanks. |
|
@leidwang the L226 is still preserving the tp-qemu/provider/block_devices_plug.py Line 225 in 879c7d7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Win11-24H2, Windows remove WMIC, so replace it with some powershell cmdlet
ID: 3268