-
Notifications
You must be signed in to change notification settings - Fork 256
Automatically benchmark new pallets in runtime-benchmark.sh #3590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NingLin-P
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!!! Thank you!
|
Failed in the merge queue, possibly due to some GitHub internal infra issues: Windows clippy: macOS tests: |
|
Failed again due to "the operation was canceled", I'm following up on Slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the runtime-benchmark.sh, making it more portable and easier to use, and automatically fetching the list of benchmarks from the runtime lib.rs files.
Bug fixes
bashis in/bin(sometimes it is in/usr/binor a custom directory in the PATH)Script Improvements
set -xinstead ofecholib.rsfilesGenerated file improvements
Close #3582
Parts of #3587
Future Work
We could move some extension benchmark weights into the runtime, I've left TODOs in the script.
Code contributor checklist: