-
Notifications
You must be signed in to change notification settings - Fork 256
Update production runtime weight #3578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d38f0ca
Fix broken benchmarks in pallet-transporter and pallet-messenger
NingLin-P 6f4464f
Update weight of the unlock_funds benchmark in pallet-domains
NingLin-P 87e0e4b
Add benchmark for XDM between domains in the pallet-messenger extension
NingLin-P ee7ba9f
Update pallet-messenger extension SubstrateWeight type
NingLin-P c977079
Export pallet WeightInfo trait
NingLin-P 86dd424
Add more (mostly upstream) pallets to runtime benchmark list
NingLin-P a6e2670
Init weights files structure in the runtime
NingLin-P 1a273f9
Add and run scripte to generate weight files
NingLin-P df64e4a
Recorrect the WeightInfo trait for the extension weight files
NingLin-P 3c79afe
Apply weight to the production runtime
NingLin-P 4933789
Fix clippy & update runtime-benchmark.sh
NingLin-P 11623ab
Merge branch 'main' of github.com:subspace/subspace into update-weight
NingLin-P File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR #3557 adds a benchmark for the balance transfer check extension. How are you going to merge those changes in this set of benchmarks? Do we need to re-run the script after it merges?
If we're soon going to remove that extension, is it worth having the weights for it in the runtime?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partially answered in https://github.com/autonomys/subspace/pull/3578/files#r2143887125.
Not really removing the extension, I think we just change the
enable_transferfromfalsetotrue, the extension is still there and we still need to do this check for every extrinsic.