Skip to content

Conversation

@nazar-pc
Copy link
Member

For benchmarking purposes template is optional and ours is not much different from default. The biggest change is that it implements weights for (), which I think we can live without just fine.

Code contributor checklist:

@nazar-pc nazar-pc requested a review from NingLin-P October 15, 2024 03:48
@nazar-pc nazar-pc requested a review from rg3l3dr as a code owner October 15, 2024 03:48
@nazar-pc nazar-pc enabled auto-merge October 15, 2024 03:48
@nazar-pc nazar-pc disabled auto-merge October 15, 2024 04:11
@nazar-pc nazar-pc added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 03f39e7 Oct 15, 2024
8 checks passed
@nazar-pc nazar-pc deleted the delete-frame-weight-template.hbs branch October 15, 2024 08:25
@teor2345
Copy link
Member

This breaks our typical benchmark use case, because we put benchmarks inside the crate, but the default template refers to the crate by name (from outside the crate).

I think everyone else might have this file locally, or they are copying from a temporary file. I discovered it because I never checked it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants