-
Notifications
You must be signed in to change notification settings - Fork 252
Add node metrics #1479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add node metrics #1479
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| //! Node metrics | ||
|
|
||
| use futures::StreamExt; | ||
| use parity_scale_codec::Encode; | ||
| use sc_client_api::{BlockBackend, BlockImportNotification, ImportNotifications}; | ||
| use sp_runtime::traits::Block as BlockT; | ||
| use std::sync::Arc; | ||
| use substrate_prometheus_endpoint::{register, Counter, PrometheusError, Registry, U64}; | ||
|
|
||
| pub struct NodeMetrics<Block: BlockT, Client> { | ||
| client: Arc<Client>, | ||
| block_import: ImportNotifications<Block>, | ||
| blocks: Counter<U64>, | ||
| extrinsics: Counter<U64>, | ||
| extrinsics_size: Counter<U64>, | ||
| _p: std::marker::PhantomData<Block>, | ||
| } | ||
|
|
||
| impl<Block, Client> NodeMetrics<Block, Client> | ||
| where | ||
| Block: BlockT, | ||
| Client: BlockBackend<Block> + 'static, | ||
| { | ||
| pub fn new( | ||
| client: Arc<Client>, | ||
| block_import: ImportNotifications<Block>, | ||
| registry: &Registry, | ||
| ) -> Result<Self, PrometheusError> { | ||
| Ok(Self { | ||
| client, | ||
| block_import, | ||
| blocks: register( | ||
| Counter::new("subspace_node_blocks", "Total number of imported blocks")?, | ||
| registry, | ||
| )?, | ||
| extrinsics: register( | ||
| Counter::new( | ||
| "subspace_node_extrinsics", | ||
| "Total number of extrinsics in the imported blocks", | ||
| )?, | ||
| registry, | ||
| )?, | ||
| extrinsics_size: register( | ||
| Counter::new( | ||
| "subspace_node_extrinsics_size", | ||
| "Total extrinsic bytes in the imported blocks", | ||
| )?, | ||
| registry, | ||
| )?, | ||
| _p: Default::default(), | ||
| }) | ||
| } | ||
|
|
||
| pub async fn run(mut self) { | ||
| while let Some(incoming_block) = self.block_import.next().await { | ||
| self.update_block_metrics(incoming_block); | ||
| } | ||
| } | ||
|
|
||
| fn update_block_metrics(&mut self, incoming_block: BlockImportNotification<Block>) { | ||
| let extrinsics = self | ||
| .client | ||
| .block_body(incoming_block.hash) | ||
| .ok() | ||
| .flatten() | ||
| .unwrap_or(vec![]); | ||
| self.blocks.inc(); | ||
| self.extrinsics.inc_by(extrinsics.len() as u64); | ||
| let total_size: usize = extrinsics | ||
| .iter() | ||
| .map(|extrinsic| extrinsic.encoded_size()) | ||
| .sum(); | ||
| self.extrinsics_size.inc_by(total_size as u64); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rahulksnv this was actually slightly incorrect and fixed in dfda03c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sg thanks