Runtime interface for solution verification#1278
Merged
Conversation
nazar-pc
requested review from
liuchengxu,
rg3l3dr and
vedhavyas
as code owners
nazar-pc
force-pushed
the
runtime-interface-for-solution-verification
branch
from
2386fff to
02765d3
Compare
nazar-pc
force-pushed
the
runtime-interface-for-solution-verification
branch
from
02765d3 to
02b3277
Compare
1 task
nazar-pc
added
breaking-consensus
vedhavyas
reviewed
Mar 21, 2023
Contributor
vedhavyas
left a comment
vedhavyas
left a comment
There was a problem hiding this comment.
Make sense to me over all. Some small details
liuchengxu
previously approved these changes
Mar 22, 2023
|
|
||
| #[cfg(feature = "std")] | ||
| sp_externalities::decl_extension! { | ||
| /// An extension to verify the fraud proof. |
Contributor
There was a problem hiding this comment.
:P
Suggested change
| /// An extension to verify the fraud proof. | |
| /// An extension to verify the solution. |
nazar-pc
force-pushed
the
runtime-interface-for-solution-verification
branch
from
02b3277 to
94db1f3
Compare
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Mar 22, 2023
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for runtime to verify solutions using host functions exposed by the client without embedding trusted setup parameters for KZG into runtime and saves a lot of computation when checking votes as the result.
It is not ideal, but this is the best thing I came up with to ensure we can author a block without timing out.
@i1i1 @ozgunozerk Check the latest commit, additional host functions need to be added to the client for this to work.
Fixes #1279
Code contributor checklist: