Initial subspace-erasure-coding implementation#1214
Merged
Conversation
5 tasks
i1i1
reviewed
Mar 6, 2023
Contributor
|
Looks OK from my side! |
nazar-pc
force-pushed
the
subspace-erasure-coding
branch
from
9671616 to
7b59e0f
Compare
Member
Author
|
Rebased against |
dariolina
reviewed
Mar 14, 2023
nazar-pc
requested review from
liuchengxu and
shamil-gadelshin
and removed request for
liuchengxu
Contributor
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Looks good. I left a small comment for tests.
dariolina
approved these changes
Mar 17, 2023
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Mar 20, 2023
i1i1
added a commit
to autonomys/subspace-pulsar-sdk
that referenced
this pull request
Mar 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces new crate that covers first 3/4 items from #1163. The last one will be added separately later, I think I'll need to unity some types to make it ergonomic first.
The code is trivial, but the challenge was that dependencies didn't install (yanked crates), then didn't compile, then it didn't support
no_stdand it took a bit of time to resolve all of those.Draft PR for now since it is not yet very useful without other pieces for v2.3 consensus and can wait for some of the upcoming PRs to land in
rust-kzg(there is still one I'll be submitting soon, waiting for another to be merged first). Hopefully it'll all land intomain, but at very least somewhere upstream rather than our fork (maintainers were quick to merge things, so shouldn't be long).Code contributor checklist: