Merged
Conversation
nazar-pc
requested review from
i1i1,
liuchengxu,
rg3l3dr,
shamil-gadelshin and
vedhavyas
as code owners
Member
Author
|
Updated revision to include paritytech/substrate#13372 |
i1i1
previously approved these changes
Feb 27, 2023
vedhavyas
previously approved these changes
Feb 27, 2023
Member
Author
|
Hm... storage monitor is not supported on Windows for now, I'll make it conditionally compilable and we can restore it fully once paritytech/substrate#13466 lands |
nazar-pc
force-pushed
the
upgrade-substrate
branch
from
78efd83 to
6237f43
Compare
vedhavyas
previously approved these changes
Feb 27, 2023
nazar-pc
force-pushed
the
upgrade-substrate
branch
2 times, most recently
from
10783e7 to
9cf171c
Compare
Member
Author
|
Okay, now I see where the issue is. So yeah... waiting for paritytech/substrate#13466 now. |
i1i1
previously approved these changes
Feb 27, 2023
nazar-pc
force-pushed
the
upgrade-substrate
branch
from
9cf171c to
4e66066
Compare
Member
Author
|
Replaced workarounds with latest Substrate ( |
2 tasks
Member
Author
|
Now wasmi crashes on Windows: paritytech/substrate#13487 |
Force using the wasmtime everythere in substrate-test-runtime-client.
Upgrade substrate fix
# Conflicts: # crates/subspace-archiving/Cargo.toml # domains/client/domain-executor/src/core_bundle_processor.rs # domains/client/domain-executor/src/system_bundle_processor.rs # domains/client/domain-executor/src/xdm_validator.rs
liuchengxu
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the changes like last time are related to upstream refactoring from
BlockId<Block>toBlock::Hash. Also node storage monitor was added.Merged into out
subspace-v3fork cleanly, continues to work with Gemini 3c without issues.Code contributor checklist: