refactor: use progress_bar more explicitly as a thread#1622
Merged
aron-bram merged 2 commits intodevelopmentfrom Nov 24, 2022
Merged
refactor: use progress_bar more explicitly as a thread#1622aron-bram merged 2 commits intodevelopmentfrom
aron-bram merged 2 commits intodevelopmentfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #1622 +/- ##
===============================================
- Coverage 83.42% 83.27% -0.15%
===============================================
Files 156 156
Lines 11927 11931 +4
Branches 1896 1897 +1
===============================================
- Hits 9950 9936 -14
- Misses 1412 1425 +13
- Partials 565 570 +5 |
eddiebergman
approved these changes
Nov 23, 2022
Contributor
eddiebergman
left a comment
There was a problem hiding this comment.
Looks good, I'll leave the documentation part up to you to decide if you want to fix it, otherwise feel free to merge it yourself!
Make sure to use the Squash and Merge option when merging, it should show on the button if not already.
eddiebergman
approved these changes
Nov 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did not like the way the progress bar class started itself as soon as it was instatiated, so I changed the way it works to be more intuitive. Namely, ProgressBar can now be used just like a regular thread, so start() has to be called on it for it to start running. Also, join is used to wait for it to finish, which at the same time terminates the thread by maxing out the bar, so that the thread will never hang.
I also added improved docs.