Skip to content

Conversation

@aron-bram
Copy link
Collaborator

@aron-bram aron-bram commented Nov 23, 2022

Fixes #1594

I noticed that the show_models() function doesn't rank according to the cost, even though its documentation says so.

The issue was that there was a loop going over an array of models that was not sorted by the costs and the code assumed it to be sorted. Another array of models was sorted however, but not used to determine the rank. So I extended this sorted array with a rank column and used it to determine the rank later.

I only touched the show_models() function in automl.py

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1621 (64bf96b) into development (1abd1f9) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1621      +/-   ##
===============================================
- Coverage        83.42%   83.22%   -0.20%     
===============================================
  Files              156      156              
  Lines            11927    11926       -1     
  Branches          1896     1896              
===============================================
- Hits              9950     9926      -24     
- Misses            1412     1433      +21     
- Partials           565      567       +2     

Impacted file tree graph

Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm, I'm surprised I let this through, I was the one reviewing it. Nice find!

@aron-bram aron-bram merged commit a978478 into development Nov 24, 2022
@aron-bram aron-bram deleted the model_ranking branch November 24, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

show_models and leaderboard show different rankings.

3 participants