fix: modify show_models() to display same ranks as leaderboard #1621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1594
I noticed that the show_models() function doesn't rank according to the cost, even though its documentation says so.
The issue was that there was a loop going over an array of models that was not sorted by the costs and the code assumed it to be sorted. Another array of models was sorted however, but not used to determine the rank. So I extended this sorted array with a rank column and used it to determine the rank later.
I only touched the show_models() function in automl.py