fix(multiprocessing): Use list instead of key-view #1609
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems some tests were failing stochastically in
AutoML::fit() -> _fit_cleanup(), many complaining thatself._loggerwasNoneand calling methods likeinfoandexceptionon thisNoneobject were failing (as expected). Scrolling further up in the stack traces, there was a seemingly unrelated failure.My guess here is that
sys.moduleswas slowly getting cleaned up by the garbage collector as cleanup was happening, causing this iteration to fail. Solution was just to wrap in alistaslist(sys.modules.keys()).Will update depending on whether this fixes the issue.