Replace deprecated DataFrame.append with pandas.concat in meta_base.py #1487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lso removed a loop that wasn't doing anything. DataFrame.append doesn't operate in place so that second loop wasn't causing any side effects, and it was also just adding empty series anyway. If anyone has any insight about why that was there in the first place that would be nice.
Codecov Report
@@ Coverage Diff @@
## development #1487 +/- ##
===============================================
- Coverage 84.22% 84.21% -0.02%
===============================================
Files 151 151
Lines 11488 11485 -3
Branches 1994 1993 -1
===============================================
- Hits 9676 9672 -4
- Misses 1279 1281 +2
+ Partials 533 532 -1 |
|
Hey @EricPedley, This seems good :) Thanks for the contribution! I couldn't tell you exactly why that was there but I trust the tests will make sure that nothing is broken. I'll run our more comprehensive benchmark and let you know, just to make sure it didn't somehow actually silently drop performance somehow by not having some information available. Best, |
|
Thanks for the contribution :) |
eddiebergman
pushed a commit
that referenced
this pull request
Aug 18, 2022
lso removed a loop that wasn't doing anything. DataFrame.append doesn't operate in place so that second loop wasn't causing any side effects, and it was also just adding empty series anyway. If anyone has any insight about why that was there in the first place that would be nice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Message of deprecation from pandas docs
The warning I'm talking about:
Also removed a loop that wasn't doing anything. DataFrame.append doesn't operate in place so that second loop wasn't causing any side effects, and it was also just adding empty series anyway. If anyone has any insight about why that was there in the first place that would be nice.
Let me know if I need to elaborate more or write tests or anything else. It's a small change to existing code so I wasn't sure if it's necessary.