-
Notifications
You must be signed in to change notification settings - Fork 96
Adding new test and docs for issue #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -572,6 +572,15 @@ def check_configuration( # noqa: D103 | |||||||
| vector: np.ndarray, | ||||||||
| allow_inactive_with_values: bool = False, | ||||||||
| ) -> None: | ||||||||
| """Checks whether a given parameter vector is valid according to the conditionals and forbiddens. | ||||||||
|
|
||||||||
| Raises an Exception if the vector is not valid. | ||||||||
|
|
||||||||
| Args: | ||||||||
| space: Configuration space | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| vector: Parameter vector | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| allow_inactive_with_values: If True, inactive parameters are allowed to have values in the vector. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| """ | ||||||||
| activated = np.isfinite(vector) | ||||||||
|
|
||||||||
| # Make sure the roots are all good | ||||||||
|
|
||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -616,6 +616,38 @@ def test_check_configuration2(): | |
| configuration.check_valid_configuration() | ||
|
|
||
|
|
||
| def test_check_configuration3(): | ||
| # Test that hyperparameters that follow the conditions and forbiddens will still be rejected if out parameter bounds | ||
| cs = ConfigurationSpace( | ||
| space=[ | ||
| NormalIntegerHyperparameter("a", mu=50, sigma=10, lower=1, upper=10), | ||
| UniformIntegerHyperparameter("b", lower=1, upper=100), | ||
| NormalFloatHyperparameter("c", lower=0, upper=1, mu=0.25, sigma=0.12), | ||
| UniformIntegerHyperparameter("d", lower=0, upper=1), | ||
| BetaFloatHyperparameter("e", lower=0, upper=1, alpha=1, beta=1), | ||
| CategoricalHyperparameter("f", ["Yes", "No", "Maybe"]), | ||
| OrdinalHyperparameter("g", ["Low", "Medium", "High"]), | ||
| ], | ||
| ) | ||
| cs.add( | ||
| NotEqualsCondition(cs["b"], cs["a"], 10), | ||
| ForbiddenEqualsClause(cs["c"], 0), | ||
| ForbiddenEqualsClause(cs["d"], 1), | ||
| ForbiddenEqualsClause(cs["e"], 0), | ||
| ForbiddenEqualsClause(cs["e"], 1), | ||
| ForbiddenAndConjunction( | ||
| ForbiddenEqualsClause(cs["f"], "No"), | ||
| ForbiddenEqualsClause(cs["g"], "Low"), | ||
| ), | ||
| ) | ||
| sample = cs.sample_configuration() | ||
| assert sample.check_valid_configuration() is None # Base sample should pass | ||
|
|
||
| # Parameter A has no conditions; check if the configuration fails if a > 10 | ||
| with pytest.raises(IllegalValueError): | ||
| sample["a"] = 101 | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this actually trigger a call to check configuration or does this fail somewhere else? |
||
|
|
||
|
|
||
| def test_check_forbidden_with_sampled_vector_configuration(): | ||
| cs = ConfigurationSpace() | ||
| metric = CategoricalHyperparameter("metric", ["minkowski", "other"]) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.