Update wheel builder to include windows and osx #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds wheels for the same distributions as supported in
sklearngithub actions.This action also runs our suite of tests on these wheels which seems to complete without error.
The output of the test can be seen here:
This also adds the
workflow_dispatchevent so that it can be triggered manually.I would still advocate for some manual testing of the wheels produced in the artifacts on a seperate windows/mac device, seperate from the environment it was built on, if possile.