Dev shuhei #88
Closed
Dev shuhei #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave not change at all.
…OSS_VAL_FN and HOLDOUT_FN as static methods
… class (CROSS_VAL_FN and HOLDOUT_FN)
… Implanted get_..._validators function into classmethod for CrossValFuncs (previously named CROSS_VAL_FN) and HoldValFuncs
… the child class does not inherit NamedTuple class
…d class of BaseNamedTuple does not inherit NamedTuple class
… removed from all the files
…e to pass unit tests
Contributor
|
There are quite a lot of conflicting changes in the datasets with Fransisco's PR #89 . I suggest we get back to this PR after we are done with his PR. |
…. united file name: resampling_strategy.py -> train_val_split.py
…anced the readability without changing function at all.
…strings as much as possible. (Have not been compatible with other files yet)
… get everything through constants.RegressionTypes and constants.ClassificationTypes
Collaborator
Author
|
I will send PRs from another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[New]