Skip to content

Set node value to -1 when ISY reports it as unknown (blank string) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmkraus merged 2 commits into from
Dec 8, 2017
Merged

Set node value to -1 when ISY reports it as unknown (blank string) #38

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8877b32
Set node value to -1 when ISY reports it as unknown (blank string)
OverloadUT Nov 26, 2017
3485256
Change "unknown" value to `-inf` and clean up whitespace trimming
OverloadUT Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PyISY/Nodes/node.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ def parse_xml_properties(xmldoc):
#print "prop=",prop.toprettyxml();
units = uom if uom == 'n/a' else uom.split('/')
if (val == ""):
val = 0
val = -1
else:
val = int(val.replace(' ', '0'))
val = int(val.replace(' ', '-1'))

@rmkraus rmkraus Nov 29, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line would cause problems if the value was ' 5'. I'm not sure if that every happens, but it feels plausible. I really don't like any of the original logic on these lines. What if we did something like this:

val = val.strip()
if val == "":
    val = -1
val = int(val)

@OverloadUT OverloadUT Nov 29, 2017

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ha, that didn't occur to me. I wasn't exactly sure what that original logic was trying to catch in the first place I couldn't get that condition to occur from my actual ISY responses. Stripping is the much better way to go; I'll change it to that.


if prop_id == STATE_PROPERTY:
state_val = val
Expand Down