Fix Property Updates, Add Timestamps, Unused Status Handling#100
Fix Property Updates, Add Timestamps, Unused Status Handling#100OverloadUT merged 7 commits intoautomicus:masterfrom
Conversation
|
@OverloadUT -- These changes support some significant improvements to how Home Assistant can handle NodeServer nodes as well as updates to sensors and eventual support for "stale values" in Home Assistant -- my plan is to tack them on to the end of the PR chain if you're willing to test and push a 2.0.3. |
OverloadUT
left a comment
There was a problem hiding this comment.
Just a couple comments!
|
I'm going to call that last commit the "you shouldn't eff with something you don't completely understand" fix. Somehow in everything I've worked on with the ISY I've missed that Fixed the update function back to what it was originally intended for and added a dedicated function to update the /rest/nodes endpoint. This requires another sync call with That's the last change I have in this round -- no extra PR required. |
Revert update function back to a separate function to call the /rest/status Add a separate function to call and reload the /rest/nodes endpoint.
|
Rebased. |
OverloadUT
left a comment
There was a problem hiding this comment.
Sorry for the delay; this one looks good to me!
Changed / Fixed
ST) unit of measurement (UOM) toISY_PROP_NOT_SET = "-1": Some NodeServer and Z-Wave nodes do not make use of theST(or status) property in the ISY and only reportaux_properties; in addition, most NodeServer nodes do not report theSTproperty when all nodes are retrieved, they only report it when queried directly or in the Event Stream. Previously, there was no way to differentiate between Insteon Nodes that don't have a valid status yet (after ISY reboot) and the other types of nodes that don't report the property correctly since they both reportedISY_VALUE_UNKNOWN. TheISY_PROP_NOT_SETallows differentiation between the two conditions based on having a valid UOM or not. Fixes Identifying nodes with no ST property #98.formattedproperty is not updated and theuom/precare updated with separate functions from outside of the Node's class. This updates the receiver to pass aNodePropertyinstance into the Node, and allows the Node to update all of it's properties if they've changed, before reporting the status change to the subscribers. This makes theformattedproperty actually useful.Added
*.last_updateand*.last_changedproperties which are UTC Datetime Timestamps, to allow detection of stale data. Fixes Add Last Updated Property to Nodes #99Fixes #98