Skip to content

Commit

Permalink
Fix temporary meter
Browse files Browse the repository at this point in the history
  • Loading branch information
arendjr committed Sep 6, 2023
1 parent 745bda3 commit 9296f10
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions packages/autometrics/src/temporaryMeter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class TemporaryMeter implements Meter {
}

const counter = new TemporaryCounter(name, options);
this._createdUpDownCounters.push(counter);
this._createdCounters.push(counter);
return counter;
}

Expand Down Expand Up @@ -220,7 +220,7 @@ export class TemporaryMeter implements Meter {

for (const counter of this._createdObservableUpDownCounters) {
counter.forward(
meter.createObservableGauge(counter.name, counter.options),
meter.createObservableUpDownCounter(counter.name, counter.options),
);
}

Expand Down
6 changes: 4 additions & 2 deletions packages/autometrics/tests/temporaryMeter.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { TemporaryMeter } from "../src/temporaryMeter";

describe("temporaryMeter test", () => {
test("it disables itself after the timeout expires", async () => {
const meter = new TemporaryMeter({ timeout: 50 });
const timeout = 50;

const meter = new TemporaryMeter({ timeout });

const counter = meter.createCounter("test.counter");
counter.add(1);
Expand All @@ -14,7 +16,7 @@ describe("temporaryMeter test", () => {
// @ts-ignore
expect(counter._addedValues.length).toBe(1);

await new Promise((resolve) => setTimeout(resolve, 50));
await new Promise((resolve) => setTimeout(resolve, timeout));

// @ts-ignore
expect(meter._createdCounters.length).toBe(0);
Expand Down

0 comments on commit 9296f10

Please sign in to comment.