Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[autometrics 1.0 compliance] add repo url and provider #152

Merged
merged 5 commits into from
Nov 9, 2023

Conversation

mellowagain
Copy link
Member

@mellowagain mellowagain commented Nov 8, 2023

fixes AM-78

Checklist

  • Changelog updated

@mellowagain mellowagain changed the base branch from autometrics-1.0 to main November 8, 2023 15:02
@mellowagain mellowagain marked this pull request as ready for review November 8, 2023 15:02
@mellowagain mellowagain requested a review from a team November 8, 2023 15:32
Copy link
Member

@gagbo gagbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the changelog (the whole Unreleased section) will need to be rewritten to match the keep a changelog spec (with the Added, Changed etc. subsections), but it can happen later when we cut the release

@hatchan
Copy link
Collaborator

hatchan commented Nov 9, 2023

I think the changelog (the whole Unreleased section) will need to be rewritten to match the keep a changelog spec (with the Added, Changed etc. subsections), but it can happen later when we cut the release

TBH I think it is fine that we do not add all the groups it just adds extra work determining in which bucket we need to put it. The only important thing that we do need to highlight (possibly on top of the version) is breaking changes.

@mellowagain mellowagain merged commit b887363 into main Nov 9, 2023
@mellowagain mellowagain deleted the repo-provider-and-url branch November 9, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants