Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Logging interface to Autometrics #80

Merged

Conversation

gagbo
Copy link
Member

@gagbo gagbo commented Nov 14, 2023

Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context.

Fixes AM-130

Checklist

  • The CHANGELOG is updated.
  • The open-telemetry example in repository works fine:
    • the docker compose file is valid
    • the application compiles and run
    • alerts are getting triggered in Prometheus
  • The prometheus example in repository works fine:
    • the docker compose file is valid
    • the application compiles and run
    • alerts are getting triggered in Prometheus
    • exemplars are accessible on the graph

@gagbo gagbo force-pushed the am-130-add-logger-interface-to-allow-autometrics-to-use-logs branch from 7bf3f15 to da17e90 Compare November 14, 2023 11:32
Copy link
Member

@mellowagain mellowagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart af, we dont follow this with -rs, we just panic on errors lol. may be smart to put it into the spec

@gagbo gagbo merged commit be7aa75 into main Nov 16, 2023
7 checks passed
@gagbo gagbo deleted the am-130-add-logger-interface-to-allow-autometrics-to-use-logs branch November 16, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants