Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the full, cleaned up module name #69

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Use the full, cleaned up module name #69

merged 4 commits into from
Oct 13, 2023

Conversation

gagbo
Copy link
Member

@gagbo gagbo commented Oct 11, 2023

Description

This uses the full package name in the module field to try and avoid with duplication.

Also this cleans up extra syntax appearing for pointer receiver methods

Ref: https://go.dev/play/p/xrdc1HRAfI8

Checklist

  • The CHANGELOG is updated.
  • The open-telemetry example in repository works fine:
    • the docker compose file is valid
    • the application compiles and run
    • alerts are getting triggered in Prometheus
  • The prometheus example in repository works fine:
    • the docker compose file is valid
    • the application compiles and run
    • alerts are getting triggered in Prometheus
    • exemplars are accessible on the graph

gagbo added 4 commits October 11, 2023 14:01
Having an unindented header is the only way to make sure that gopls will
correctly render the documentation of an instrumented function with the
links
@gagbo gagbo merged commit a93554a into main Oct 13, 2023
7 checks passed
@gagbo gagbo deleted the full_module_name branch October 13, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants