Add support for push-gateway and OTLP #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagbo
force-pushed
the
otlp_push
branch
2 times, most recently
from
62b66d3 to
d7d683c
Compare
gagbo
changed the title
gagbo
force-pushed
the
otlp_push
branch
3 times, most recently
from
6822648 to
0f137e5
Compare
gagbo
force-pushed
the
otlp_push
branch
7 times, most recently
from
8087511 to
5c28d1a
Compare
gagbo
force-pushed
the
otlp_push
branch
2 times, most recently
from
790f493 to
97bb5fa
Compare
mellowagain
approved these changes
Sep 15, 2023
| // This is a useful function to use for setting a `job` key when | ||
| // pushing metrics | ||
| func GetOutboundIP() (net.IP, error) { | ||
| conn, err := net.Dial("tcp", "1.1.1.1:80") |
There was a problem hiding this comment.
eehh this may be nasty behavior imo, it is quite unexpected for the autometrics library to make connections to the wide internet. definitely need to document this behavior more obviously
| if pushConfiguration.CollectorURL == "" { | ||
| return nil, errors.New("invalid PushConfiguration: the CollectorURL must be set.") | ||
| } | ||
| autometrics.SetPushJobURL(pushConfiguration.CollectorURL) |
There was a problem hiding this comment.
what is the behavior if a url without /v1/metrics at the end gets inputted?
There was a problem hiding this comment.
Golang prometheus library adds that part itself, so it should be fine not adding the extra specification here. In the docs they don't mention the v1 part, but the gateway URL is still supposed to just be the root of the gateway.
Forced to update opentelemetry-go as well as there was no way to bring the update without also going into otel breaking changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for using "push"-based workflows with metrics:
...autometrics-go/prometheus), autometrics will push the metrics to a given Push Gateway...autometrics-go/otel), autometrics will push OTLP metrics periodically to a collector.This also forcefully updates opentelemetry libraries to 1.17/0.40
Checklist