Skip to content

check endpoint for 2xx status code on am start #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 14, 2023
Merged

check endpoint for 2xx status code on am start #25

merged 3 commits into from
Jun 14, 2023

Conversation

mellowagain
Copy link
Member

fixes #11

hatchan
hatchan reviewed Jun 13, 2023
View reviewed changes
Copy link
Contributor

@hatchan hatchan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also add a little test that will spinup a http server that will either return a successful or a non-successful status code.

Come to think of it, it might be a bit overkill.

@mellowagain mellowagain requested a review from hatchan June 14, 2023 09:15
@mellowagain mellowagain merged commit ba4ebe5 into main Jun 14, 2023
@mellowagain mellowagain deleted the endpoint-check branch June 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hatchan hatchan hatchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check if the provided endpoints work for am
2 participants
@mellowagain @hatchan