[namastex888]

Two fixes: (1) team-lead AGENTS.md uses genie work (auto-inits state + spawns), no separate genie spawn. (2) Wish template includes QA Criteria section.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4722bbe0-6f76-4e11-b729-aa8ba247675b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/team-lead-workflow-v2

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the development workflow by introducing a dedicated QA criteria section within the wish-template, aiming to standardize and improve post-merge verification. Concurrently, it refines the team-lead agent's operation by integrating genie work directly, simplifying its initialization and spawning processes for a more efficient workflow.

Highlights

• Wish Template Enhancement: A new 'QA Criteria' section has been added to the wish-template.md file, providing a structured checklist for verifying functional, integration, and regression aspects after a merge.
• Agent Workflow Streamlining: The team-lead agent workflow has been updated to directly utilize genie work, which handles state initialization and spawning, removing the need for a separate genie spawn step.

Changelog

• plugins/genie/references/wish-template.md
  • Added a new 'QA Criteria' section with a detailed checklist for post-merge verification.
  • Updated the descriptive text for the 'Review Results' section.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the wish-template.md file by introducing a new 'QA Criteria' section and making the 'Review Results' description more generic. While adding a dedicated QA section is a positive step for process clarity, I've identified a potential for confusion with existing terminology. My review includes a suggestion to align the naming of criteria sections to ensure consistency with the documented agent behaviors.

[gemini-code-assist]

The introduction of a "QA Criteria" section may cause confusion, as the qa.md agent documentation specifies that it validates "acceptance criteria". This discrepancy could lead to the new section being ignored by the agent or create ambiguity with the existing "Acceptance Criteria" defined within execution groups.

To improve clarity and ensure the process is unambiguous, please consider one of the following:

1. Rename the section if its purpose differs from the per-group acceptance criteria (e.g., ## Post-Merge Verification).
2. Differentiate the existing criteria if this new section is intended for the QA agent. For example, rename the criteria in execution groups to Developer Acceptance Criteria.
3. Clarify the relationship in the description. Explain if these QA criteria are a summary of, or distinct from, the execution group acceptance criteria.