Repository navigation
fix: inline SOUL+HEARTBEAT in team-lead, pre-hire team, force cache bust - #586
Conversation
… work in system prompts
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refines the operational logic of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request inlines SOUL and HEARTBEAT content into the team-lead agent's prompt and standardizes some commands. The changes are mostly good, but I've found a few issues where the workflow seems to be broken due to missing commands after spawning agents (reviewer, fix, qa). Additionally, there's a potential security vulnerability in the gh pr create command construction and a loss of clarity in the gh pr merge instruction. My review comments provide details and suggestions for these points.
| ```bash | ||
| genie team hire reviewer --team <your-team-name> | ||
| genie review reviewer <slug> | ||
| genie spawn reviewer --team <your-team-name> |
There was a problem hiding this comment.
The reviewer agent is spawned, but it's not given a task. The command to dispatch the review work is missing. A command to assign the work should be added after spawning the agent to ensure the lifecycle can proceed.
| genie spawn reviewer --team <your-team-name> | |
| genie spawn reviewer --team <your-team-name> | |
| genie work reviewer <slug>#review |
| ```bash | ||
| genie team hire fix --team <your-team-name> | ||
| genie work fix <slug>#fix | ||
| genie spawn fix --team <your-team-name> |
There was a problem hiding this comment.
Similar to the reviewer, the fix agent is spawned but not assigned a task. The genie work fix <slug>#fix command is missing, which breaks the fix-re-review loop.
| genie spawn fix --team <your-team-name> | |
| genie spawn fix --team <your-team-name> | |
| genie work fix <slug>#fix |
| gh pr create --base dev --title "<concise title>" --body "## Summary | ||
| <bullets> | ||
|
|
||
| ## Wish | ||
| <slug> | ||
|
|
||
| ## Test plan | ||
| <checklist> | ||
| EOF | ||
| )" | ||
| <checklist>" |
There was a problem hiding this comment.
The new formatting for the --body of the gh pr create command uses a double-quoted string. This is vulnerable to shell command injection if placeholders like <slug> contain shell metacharacters (e.g., $(...)). The previous implementation using a cat <<'EOF' heredoc was safer. It's recommended to revert to a safer method to prevent potential security issues.
| gh pr create --base dev --title "<concise title>" --body "## Summary | |
| <bullets> | |
| ## Wish | |
| <slug> | |
| ## Test plan | |
| <checklist> | |
| EOF | |
| )" | |
| <checklist>" | |
| gh pr create --base dev --title "<concise title>" --body "$(cat <<'EOF' | |
| ## Summary | |
| <bullets> | |
| ## Wish | |
| <slug> | |
| ## Test plan | |
| <checklist> | |
| EOF | |
| )" |
| ```bash | ||
| genie team hire qa --team <your-team-name> | ||
| genie work qa <slug>#qa | ||
| genie spawn qa --team <your-team-name> |
There was a problem hiding this comment.
The qa agent is spawned, but the command to dispatch the QA task, genie work qa <slug>#qa, is missing. Without it, the QA step in the lifecycle cannot be executed.
| genie spawn qa --team <your-team-name> | |
| genie spawn qa --team <your-team-name> | |
| genie work qa <slug>#qa |
| ```bash | ||
| genie team hire reviewer --team <your-team-name> | ||
| genie review reviewer <slug> | ||
| genie spawn reviewer --team <your-team-name> |
There was a problem hiding this comment.
The reviewer agent is spawned, but it's not given a task. The command to dispatch the review work is missing. A command to assign the work should be added after spawning the agent to ensure the lifecycle can proceed.
| genie spawn reviewer --team <your-team-name> | |
| genie spawn reviewer --team <your-team-name> | |
| genie work reviewer <slug>#review |
| ```bash | ||
| genie team hire fix --team <your-team-name> | ||
| genie work fix <slug>#fix | ||
| genie spawn fix --team <your-team-name> |
There was a problem hiding this comment.
Similar to the reviewer, the fix agent is spawned but not assigned a task. The genie work fix <slug>#fix command is missing, which breaks the fix-re-review loop.
| genie spawn fix --team <your-team-name> | |
| genie spawn fix --team <your-team-name> | |
| genie work fix <slug>#fix |
| gh pr create --base dev --title "<concise title>" --body "## Summary | ||
| <bullets> | ||
|
|
||
| ## Wish | ||
| <slug> | ||
|
|
||
| ## Test plan | ||
| <checklist> | ||
| EOF | ||
| )" | ||
| <checklist>" |
There was a problem hiding this comment.
The new formatting for the --body of the gh pr create command uses a double-quoted string. This is vulnerable to shell command injection if placeholders like <slug> contain shell metacharacters (e.g., $(...)). The previous implementation using a cat <<'EOF' heredoc was safer. It's recommended to revert to a safer method to prevent potential security issues.
| gh pr create --base dev --title "<concise title>" --body "## Summary | |
| <bullets> | |
| ## Wish | |
| <slug> | |
| ## Test plan | |
| <checklist> | |
| EOF | |
| )" | |
| <checklist>" | |
| gh pr create --base dev --title "<concise title>" --body "$(cat <<'EOF' | |
| ## Summary | |
| <bullets> | |
| ## Wish | |
| <slug> | |
| ## Test plan | |
| <checklist> | |
| EOF | |
| )" |
| ```bash | ||
| genie team hire qa --team <your-team-name> | ||
| genie work qa <slug>#qa | ||
| genie spawn qa --team <your-team-name> |
There was a problem hiding this comment.
The qa agent is spawned, but the command to dispatch the QA task, genie work qa <slug>#qa, is missing. Without it, the QA step in the lifecycle cannot be executed.
| genie spawn qa --team <your-team-name> | |
| genie spawn qa --team <your-team-name> | |
| genie work qa <slug>#qa |
| gh pr merge <number> --merge | ||
| ``` | ||
| If false, leave PR open for human review. | ||
| Check autoMergeDev config. If true, merge. If false, leave PR open for human review. |
There was a problem hiding this comment.
The explicit gh pr merge command has been removed, making the instruction for the agent less precise. While the text mentions merging, providing the exact command in a code block would improve clarity and reduce ambiguity for the agent. Consider restoring the command block, for example:
Check autoMergeDev config. If true, merge:
```bash
gh pr merge <number> --mergeIf false, leave PR open for human review.
| gh pr merge <number> --merge | ||
| ``` | ||
| If false, leave PR open for human review. | ||
| Check autoMergeDev config. If true, merge. If false, leave PR open for human review. |
There was a problem hiding this comment.
The explicit gh pr merge command has been removed, making the instruction for the agent less precise. While the text mentions merging, providing the exact command in a code block would improve clarity and reduce ambiguity for the agent. Consider restoring the command block, for example:
Check autoMergeDev config. If true, merge:
```bash
gh pr merge <number> --mergeIf false, leave PR open for human review.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a2b9f593a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| genie spawn engineer --team <your-team-name> | ||
| genie work engineer <slug>#<group> |
There was a problem hiding this comment.
genie work already performs the worker spawn (workDispatchCommand calls handleWorkerSpawn in src/term-commands/dispatch.ts), and handleWorkerSpawn rejects a live duplicate role in the same team (src/term-commands/agents.ts duplicate-role guard). With this new sequence, genie spawn engineer --team ... creates a live engineer and the immediately following genie work engineer ... will fail with the duplicate-role error, so group execution blocks at the first dispatch.
Useful? React with 👍 / 👎.
| ```bash | ||
| genie team hire reviewer --team <your-team-name> | ||
| genie review reviewer <slug> | ||
| genie spawn reviewer --team <your-team-name> |
There was a problem hiding this comment.
Switching this step to plain genie spawn reviewer (same pattern also used for fix and qa) drops the wish/group dispatch context that these roles depend on. spawn only launches an agent shell, while context injection for review/work happens in the dispatch commands (src/term-commands/dispatch.ts), so reviewers/fixers/qa can be started without assigned criteria or scope and the quality gates may stall or evaluate the wrong target.
Useful? React with 👍 / 👎.
Fixes
Key change
Team-lead AGENTS.md now has the SOUL ("delegation over doing, NEVER write code") and HEARTBEAT (inbox/status/worker check loop) inlined directly. No @imports.