Repository navigation
docs(wish): skills-everywhere G7 real-host evidence + final-gate ledger - #2869
Conversation
… ledger Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f07ab8c3b4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - `Update available: 5.260830.16 → 5.260830.20` → `✔ Genie v5.260830.20 verified` | ||
| - `skills: installed 22 skill(s) from automagik-dev/genie@v5.260830.20 into 4 agent dir(s)` | ||
| - 18 `retired <surface>: <path>` lines: codex-plugin-registration (config.toml), codex-plugin-cache 1.0.0, 7× codex-role-agent, claude-plugin-registry, 2× claude-plugin-cache, claude-marketplace-registration, claude-enabled-plugin, claude-workflow (council.js), hermes-plugin-link, pi-extension-link |
There was a problem hiding this comment.
On the stated full-surface host, line 3 says the Hermes config refs were present, but this exhaustive 18-line list includes only hermes-plugin-link; it omits the separately classified hermes-mcp-server and hermes-skills-external-dir surfaces. retireLegacyIntegrations emits every removed surface and every kept modified/unmanaged surface separately, yet the evidence records neither outcome for these refs. Since C3 gates Wish B on retiring or explaining every legacy asset, keep C3 open until the evidence shows what happened to both Hermes config entries.
Useful? React with 👍 / 👎.
|
|
||
| ## After-state assertions | ||
|
|
||
| - `grep -c 'genie@automastik|genie@automagik' ~/.codex/config.toml` → 0; diff vs before shows **only** the genie plugin table + hook trust rows removed, everything else byte-identical |
There was a problem hiding this comment.
This command uses grep's default basic-regexp mode, where the unescaped | is literal, so it reports a count of zero even when config.toml still contains [plugins."genie@automagik"]. Checked against grep --help, which assigns alternation-capable extended expressions to -E; use grep -Ec (and fix the automastik typo) or separate fixed-string checks so this assertion can actually detect a surviving registration.
Useful? React with 👍 / 👎.
Squash of three review-round commits (rewritten for commitlint subject-case): evidence corrections from review round 1; high-1 remeasured (57 homes written vs 4 recorded, 77-agent registry, 1,166 would-be orphans, operator-facing misreport) with the re-scoped Wish B recording pre-condition; G7 evidence-review SHIP + collision-check note; all seven groups complete. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3
6e23de4 to
638db8f
Compare
Closes the Wish A ledger: G7 (C3) real-host dogfood evidence from khal-labs against dev v5.260830.20 — 18 legacy surfaces retired backup-first, second run
nothing to retire, doctorskills: claude/agents/goose/windsurf 22/22+legacy integrations: retired, config.toml diff = genie rows only. Plus the final-gate SHIP block, C2 wording amendment (skills: agents), and C3/C4/C6 ticked. Docs only.🤖 Generated with Claude Code
https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3