Repository navigation
docs(wish): record the #2817 FIX-FIRST review and fix disposition in the dual-mode Orca ledger - #2828
Conversation
…the dual-mode Orca ledger Orchestrator write for review M11: WISH status APPROVED → IN_PROGRESS, the PR-review evidence block (pinned SHA, validations, severity-tagged gaps, fix PR map) appended under Review Results, and the INDEX entry moved Ready → Poured with the same summary. Acceptance boxes stay unticked until the clean re-review. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6565c55263
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| loses all tool-surface board access; M10 dead launcher validator; M11 this ledger not advanced. Root causes fixed | ||
| outside the wish scope during the same review: `version.yml` executes from `main` under `workflow_run`, so the | ||
| ninth version field never synced on dev and no dev tarball shipped after v5.260829.4; `tar -xzf` without `-p` broke | ||
| `genie update` under umask 077. |
There was a problem hiding this comment.
When this ledger is used to determine whether the release and updater regressions remain blockers, it says both root causes were “fixed,” but the following disposition identifies their corrective PRs (#2822 and #2824) as still open, and neither correction is present in this commit's tree. Record these as found with fixes pending until those PRs merge; otherwise the historical ledger can incorrectly signal that the missing dev tarballs and umask-077 update failure are already resolved.
Useful? React with 👍 / 👎.
* ci(commitlint): pin the four #2817 review-wave squash subjects Three squash-merge headers (#2828, #2829, #2837) crossed 100 characters only because GitHub appended the PR suffix, and #2830's subject is capitalised ("Orca-mode"). They are already on shared dev, so — matching every prior exception in this file — pin the exact full subjects instead of rewriting history. The rolling promotion #2817 fails Commit Messages on that range until this lands. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3 * ci(commitlint): also pin the #2840 squash subject Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013gGxGgKskzyzr1HRUB6cV3 --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Orchestrator write for review gap M11 (wish ledger not advanced while A1–A7 were already merged).
WISH.mdstatusAPPROVED→IN_PROGRESS; PR-review evidence block appended under## Review Results: pinned SHAeccf0ae4a, validations run, severity-tagged gaps (H1–H6, M1–M11), and the fix-PR disposition (fix(update): admit umask-restricted release payloads and re-sync orca-plugin.json #2821/ci(release): stop gating dev releases on the committed Orca manifest version #2823/ci(orca): bind the shipped Orca plugin bundle to its TypeScript source #2825 merged; fix(update): preserve archived modes on extraction so admission survives umask 077 #2824/fix(update): never abort delivery on the Orca ownership-marker refresh #2827/ci(version): sync plugins/genie/orca-plugin.json in the auto-version bump #2822/docs: retire stale MCP/pm references and add kimi command orphan check #2826 open; adapter-readback + mode-guards in flight)..genie/INDEX.mdentry moved Ready → Poured with the same summary (satisfies thejar: index-lane driftdoctor lint for a wish in Work/Review).bun run wishes:lint→ OK. Touches only.genie/; no overlap with #2826'sCLAUDE.mdedits.🤖 Generated with Claude Code
https://claude.ai/code/session_018QrkgYMEEhrWTUo5E7Nkjg