Repository navigation
fix(router): bypass Genie when lifecycle adds no value - #2723
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
c0847ae to
d8688e6
Compare
|
can you rebase your PR`s to dev pls? :) @lirazsiri |
…s exempt Maintainer revision of the bypass policy, rebased onto dev: - every bypass is announced in one line with a 'use genie' override - security-sensitive changes keep lifecycle review gates by default; only an explicit user choice skips them - bug reports (report), operational commands, and Genie questions are cheap and never bypassed — resolves the contradiction with the intent-classification table and skill catalog - value-gate criteria get a worked example each; uncertainty inspection bounded to the two ls commands plus files the request names - skill description keeps bug/question routing discoverable - content-contract test pins policy invariants instead of full sentences - mirrors regenerated via sync-plugin-skills --write
d8688e6 to
836837f
Compare
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 836837f37d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| Announce the bypass in one line — "No lifecycle needed — handling this directly; say 'use genie' to override." — then proceed. The bypass must not create or update `.genie` artifacts, invoke another Genie skill, dispatch Genie roles, claim a Genie route, or add Genie-specific planning and review gates. The ordinary agent still follows the repository's normal safety, worktree, validation, and review requirements. | ||
|
|
||
| This is a value gate, not a word or file-count heuristic. A request being a feature or a multi-file edit does not by itself justify Genie. Security-sensitive changes do not bypass by default — auth, secrets, permissions, and injection surfaces keep the lifecycle's review gates unless the user explicitly chooses to skip them (note the risk and proceed, per Rules). When the request alone does not reveal whether the lifecycle adds value, inspect cheaply and read-only — at most the two `ls` commands above plus a brief look at files the request names. Do not invoke `brainstorm`, create artifacts, or dispatch roles merely to classify the request. Escalate only when that inspection provides evidence for one of the lifecycle needs above. |
There was a problem hiding this comment.
When lifecycle value is unclear, this caps inspection at the two earlier ls ... | wc -l commands from the bare-invocation block, which only return counts. In a repo with an existing related wish or brainstorm, the router needs the directory names to do the topic/slug comparison required just above; otherwise it can wrongly bypass instead of resuming persisted state. Point this at the state-detection listing command or otherwise allow listing the slugs.
Useful? React with 👍 / 👎.
What changed
Why
The router currently sends every clear feature, fuzzy request, or bug report into a durable Genie workflow. That imposes substantial token, latency, artifact, and orchestration costs even when ordinary agent execution is sufficient.
The new policy activates Genie only when the user asks for it, related lifecycle state exists, or the work demonstrably needs durable planning, unresolved product or architecture decisions, coordinated workstreams, or tracking across sessions or handoffs. Being a feature, bug, security-sensitive change, or multi-file edit is not enough by itself.
Impact
Simple and otherwise ordinary requests avoid Genie-specific artifacts, roles, announcements, and review gates. Existing wishes still resume through persisted state, and repository safety, worktree, validation, and review requirements continue to apply outside Genie.
Validation
bun scripts/sync-plugin-skills.ts --checkbun test scripts/release-docs.test.ts scripts/sync-plugin-skills.test.ts(26 passed)git diff --check